Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Convert luma object to singleton #2083

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 28, 2024

For #

Background

  • Convert luma API to a singleton instead of static functions.
  • Reduces the amount of global state and makes the code significantly more maintainable.

Differences

  • The luma API namespace will now have a prototype field, and that would technically become visible in the script version.
  • The browser luma object will now expose not just log and version, but also createDevice etc.

Change List

  • As above

Next Steps

  • Move the luma.gl init.ts code into the Luma singleton.

@ibgreen ibgreen force-pushed the ib/luma-object branch 2 times, most recently from 984a1a8 to d216f1b Compare April 28, 2024 22:18
@ibgreen ibgreen merged commit fb299aa into master Apr 29, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/luma-object branch April 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant