Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Clean up WebGLStateTracker #2087

Merged
merged 4 commits into from
Apr 29, 2024
Merged

chore(core): Clean up WebGLStateTracker #2087

merged 4 commits into from
Apr 29, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Apr 29, 2024

For #

Background

  • Streamline the WebGL state management API to make it easier to work with.
  • Only low risk changes in this PR.

Change List

  • Get rid of duplicated ways of calling push and pop on webgl state.
  • Prefer device.{push,pop}State methods.

@ibgreen ibgreen merged commit 32d9fff into master Apr 29, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/state-tracker branch April 29, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen