Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert feat(shadertools) Export Uniform types (#2108) #2110

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Revert feat(shadertools) Export Uniform types (#2108) #2110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/shadertools/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export type {ShaderModule} from './lib/shader-module/shader-module';
export type {ShaderPass} from './lib/shader-module/shader-pass';
export type {ShaderHook} from './lib/shader-assembly/shader-hooks';
export type {ShaderInjection} from './lib/shader-assembly/shader-injections';
export type {UniformDataType, UniformFormat} from './types';
export {ShaderModuleInstance} from './lib/shader-module/shader-module-instance';

// ShaderAssembler
Expand Down
2 changes: 2 additions & 0 deletions modules/shadertools/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ export {TypedArray, NumberArray, NumericArray} from '@math.gl/types';
// export type BigIntOrNumberArray = NumberArray | BigIntTypedArray;

// UNIFORM TYPES
// These are "duplicated" from core module to avoid cross-dependencies

export type UniformDataType = 'uint32' | 'sint32' | 'float32';

export type UniformFormat =
Expand Down
Loading