feat(types): Add bounds types #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10115209487Details
💛 - Coveralls |
felixpalmer
approved these changes
Jul 26, 2024
| | [[number, number], [number, number]] | ||
| | [[number, number, number], [number, number, number]]; | ||
|
|
||
| Any javascript typed array, or any javascript array containing numbers |
There was a problem hiding this comment.
JavaScript seems to be more common that javascript in our docs
| export type Bounds3D = [[number, number, number], [number, number, number]]; | ||
|
|
||
| /** 2 or 3 dimensional bounds [[minX, minY], [maxX, maxY]] or [[minX, minY, minZ], [maxX, maxY, maxZ]] */ | ||
| export type Bounds = |
There was a problem hiding this comment.
Why not type Bounds = Bounds2D | Bounds3D?
There was a problem hiding this comment.
Why not type Bounds = Bounds2D | Bounds3D?
Yes, this is due to one of my personal preferences. I really like being able to see the actual type definition when I hover over a type in vscode.
By referencing intermediary types, things get obscured and I need to chase down the definition of those types, so if it is easy to type it out I usually do.
But the trend is towards ever more sophisticated typescript types so I am probably on the losing side of history here.
Co-authored-by: felixpalmer <felixpalmer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For visgl/deck.gl#8933 (comment)