Set O_CLOEXEC when opening a network namespace #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fanjiyun <fan.jiyun@zte.com.cn>
|
@vishvananda PTAL |
|
@vishvananda @tklauser ptal |
|
FWIW, |
|
@aboch can you help out getting this merged? |
aboch
approved these changes
Jul 9, 2020
|
@thaJeztah @tklauser @aboch is there anything I need to do for this PR? thanks. |
|
ping @vishvananda |
|
Also, @vishvananda are you interested in having more maintainers added to this repository to help out? If so, I can look for some people to help on that. |
|
this looks good. Pull requests are so rare to this repo i haven't been paying attention. I could add @aboch to have a backup |
|
Thanks! Yes, looks like it's fairly stable/low maintenance. Having @aboch added (if he's interested 🤗) would be appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set O_CLOEXEC when opening a network namespace
Fix: moby/moby/issues/41136
the container‘s netns fds leak, causing the container netns to not clean up successfully after the container stop
Signed-off-by: fanjiyun fan.jiyun@zte.com.cn