Optional self object to avoid poor with performance
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a crazy performance increase: 490ms -> 27ms Running the benchmarks shows jade-self takes 27ms, where jade takes 490ms. The fastest non-jade templating engine was ejs and it ran the test in 89ms. Go Jade! |
|
merging! I like |
tj
added a commit
that referenced
this pull request
May 14, 2011
Optional `self` object to avoid poor `with` performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it could be good to have an optional
selfnamespace to hold the locals, so you can avoidwithpoor performance and name collision with helpers.The default would be using
withas it is right now.