Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few conditions to improve nodejs support #440

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

PaulMaly
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.873% when pulling ce4b409 on PaulMaly:master into 3503442 on visionmedia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.873% when pulling ce4b409 on PaulMaly:master into 3503442 on visionmedia:master.

@PaulMaly
Copy link
Contributor Author

Made the code is a little bit pretty.

@matthewp
Copy link
Collaborator

Perfect, thank you! Would be interested in how you are using page.js in Node. I might want to add a few Node tests in the future. Maybe create an issue?

@matthewp matthewp merged commit d46f088 into visionmedia:master Jan 15, 2018
@matthewp
Copy link
Collaborator

I plan on doing a patch release tomorrow btw.

@PaulMaly
Copy link
Contributor Author

@matthewp Thanks, it would be great. I'm glad that I able to come back to the main repo.

Would be interested in how you are using page.js in Node. I might want to add a few Node tests in the future. Maybe create an issue?

Sure, but nothing special there.

@matthewp
Copy link
Collaborator

1.7.2 is out and contains this fix: https://github.com/visionmedia/page.js/releases/tag/1.7.2

@PaulMaly
Copy link
Contributor Author

@matthewp Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants