Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: overhaul #55

Merged
merged 2 commits into from
Aug 4, 2019
Merged

ci: overhaul #55

merged 2 commits into from
Aug 4, 2019

Conversation

Thomaash
Copy link
Member

@Thomaash Thomaash commented Aug 3, 2019

  • Use Vis Bot GitHub account.
  • Build before NPM publish: places the proper version into the files.
  • Lint TypeScript.
  • Don't trigger release outside of master branch (it didn't release, but took quite a lot of time to just say “not publishing”).

Addresses #53.

- Use Vis Bot GitHub account.
- Build before NPM publish: places the proper version into the files.
- Lint TypeScript.
- Don't trigger release outside of master branch (it didn't release, but
took quite a lot of time to just say “not publishing”).
@Thomaash
Copy link
Member Author

Thomaash commented Aug 3, 2019

Hi @mojoaxel, do we have higher quality logo for our new bot? I found 100×100 px in the repos but GitHub shows it at 272×272 px.

@Thomaash Thomaash requested a review from mojoaxel August 3, 2019 16:08
.circleci/config.yml Outdated Show resolved Hide resolved
mojoaxel
mojoaxel previously approved these changes Aug 3, 2019
Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the eMail-adresse of the bot to something generic like vis-bot@gmail.com and give the credentials to all maintainers!

@Thomaash
Copy link
Member Author

Thomaash commented Aug 3, 2019

vis-bot@gmail.com is invalid, vis.bot is taken.

@mojoaxel
Copy link
Member

mojoaxel commented Aug 3, 2019

vis-bot@gmail.com is invalid, vis.bot is taken.

visjs.bot@gmail.com

@Thomaash
Copy link
Member Author

Thomaash commented Aug 3, 2019

Already waiting for verification SMS for this one.

@Thomaash
Copy link
Member Author

Thomaash commented Aug 3, 2019

visjsbot@gmail.com is ours.

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thx!

@Thomaash Thomaash merged commit 43c9459 into visjs:master Aug 4, 2019
@Thomaash Thomaash deleted the ci-overhaul branch August 4, 2019 13:01
@vis-bot
Copy link
Collaborator

vis-bot commented Aug 9, 2019

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants