Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accent #1543

Merged
merged 6 commits into from
May 30, 2024
Merged

Accent #1543

merged 6 commits into from
May 30, 2024

Conversation

ptbrowne
Copy link
Collaborator

  • Created project in Accent
  • Imported translations to Accent
  • Added config and scripts to push / pull translations to Accent

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 7:23am

@wereHamster
Copy link

wereHamster commented May 29, 2024 •
edited
Loading

Accent supports showing comments in the UI (only in gettext files though): mirego/accent#135 (comment)

I was never able to test that, since all my project use JSON and not gettext files. It looks like accent sync does not include any comments in generated .po files (judging by the diff):

image

@ptbrowne
Copy link
Collaborator Author

ptbrowne commented May 30, 2024 •
edited
Loading

Thanks for this, I opened a new issue for Accent so that they preserve the comments when pulling. To circumvent this problem and preserve comments, I now re-run lingui extract after pulling the locales from accent. It seems it does the job well. Now the diff of this PR is much cleaner :)

bprusinowski
bprusinowski approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Will the client have access to Accent, or is it for our internal purposes?

README.md Show resolved Hide resolved
package.json Show resolved Hide resolved
@ptbrowne
Copy link
Collaborator Author

Internal purposes, I expect that this way it will be easier to share translations with @KerstinFaye

@ptbrowne ptbrowne merged commit 03e8e93 into main May 30, 2024
5 of 7 checks passed
@ptbrowne ptbrowne deleted the feat/accent branch May 30, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptbrowne @wereHamster @bprusinowski