refactor: migrate to weaker pseudo random number generator #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Cuid
is akin to aGuid
and should not be considered cryptographically secure, it makes no sense to have the structure rely onSystem.Security.Cryptography.RandomNumberGenerator
for generating the value ofCuid._r
.Therefore
SecureRandom()
has been renamed toRandom()
and will call a static property inCuid.Context
that relies onSystem.Random
instead which generates enough randomness to ensure uniqueness.As a result, the performance of generating a
Cuid
improved to be much closer toGuid
:Before
After
Signed-off-by: Alan Brault alan.brault@visus.io