-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul: Fix '_consul_lan_servers' variable to resolve 'hostvars[' ']' not defined' #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable 'hostvars[' ']' not defined' error issue #437
vitabaks
changed the title
Consul: Fixing _consul_lan_servers variable to resolve 'hostvars[' ']' not defined'
Consul: Fixi _consul_lan_servers variable to resolve 'hostvars[' ']' not defined'
Aug 18, 2023
vitabaks
changed the title
Consul: Fixi _consul_lan_servers variable to resolve 'hostvars[' ']' not defined'
Consul: Fix '_consul_lan_servers' variable to resolve 'hostvars[' ']' not defined'
Aug 18, 2023
FYI @ThomasSanson
this once again shows the need for tests for the Type C scheme It will be necessary to allocate time and try again to add a scheme with consul to the molecule tests - #375 |
Test result: passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #437
In this PR, we addressed issues related to the formatting of the
consul_servers
and_consul_lan_servers
variables.The variable was previously formatted in a way that led to unnecessary line breaks and empty list elements. This caused errors when attempting to access mandatory variables from hostvars.
To fix this, we refactored the variable definition code to ensure that the list is properly formatted without extraneous whitespace, line breaks, or empty elements. This adjustment will enhance the reliability of the variable and prevent issues like the '
Mandatory variable 'hostvars[' ']' not defined
' error.The commit after which the variables were "broken": 51f17d6#diff-bfe4d1591b7e700567edc1a7cd12f30615d1bf0ec4e639b789c2e0a0fbcc7eb4