feat: add typings #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls take a look @vitalets |
vitalets
reviewed
Apr 23, 2020
| type: "BigImage"; | ||
| image_id?: string; | ||
| title?: string; | ||
| descriptions?: string; |
There was a problem hiding this comment.
Suggested change
| descriptions?: string; | |
| description?: string; |
vitalets
requested changes
Apr 23, 2020
| items: Array<string | Button>, | ||
| defaults?: Button | ||
| ): Button[]; | ||
| declare function audio(name: string): void; |
There was a problem hiding this comment.
Эта штука возвращает объект с одним полем tts. Думаю, можно сделать тип ResponseTts и все функции влияющие на аудио-часть (audio(), effect(), pause(), tts()) будут возвращать его.
По аналогии можно сделать ResponseText для text(), br().
| two: string, | ||
| five: string | ||
| ): void; | ||
| declare function enumerate(list: any[]): void; |
| ): void; | ||
| declare function enumerate(list: any[]): void; | ||
|
|
||
| declare function userify(userId: string, target: typeof reply): typeof reply; |
| declare function enumerate(list: any[]): void; | ||
|
|
||
| declare function userify(userId: string, target: typeof reply): typeof reply; | ||
| declare function userify( |
There was a problem hiding this comment.
Мне кажется, эту функцию можно одной декларацией описать через дженерик. Она всегда возвращает тип, который у target. Только вот по синтаксису как это описать в ts не знаю.
| seconds?: number; | ||
| leading: boolean; | ||
| }, | ||
| response: any |
There was a problem hiding this comment.
по идее здесь передается Response, только без end_session.
| button?: Button; | ||
| } | ||
| ): { | ||
| type: "BigImage"; |
There was a problem hiding this comment.
завести BigImageCard, чтобы не дублировать это описание?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heya i added typescript typings to use it in here as default rendering engine