Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IClient.release() has no return type annotation #854

Closed
Lehks opened this issue Nov 26, 2022 · 4 comments
Closed

IClient.release() has no return type annotation #854

Lehks opened this issue Nov 26, 2022 · 4 comments

Comments

@Lehks
Copy link

Lehks commented Nov 26, 2022

Pretty much what it says in the title. The method IClient.release() lacks a return type annotation. Recently, TypeScript has started to raise an error because of this (I am not entirely sure why).

@Lehks
Copy link
Author

Lehks commented Nov 26, 2022

I just looked up the history of the file pg-subset.d.ts and it seems like commit 6ace7 is the culprit. The release() declaration was added by that commit.

@IvanPizhenko
Copy link

IvanPizhenko commented Nov 26, 2022

I'm also facing this issue with v10.15.3:

node_modules/pg-promise/typescript/pg-subset.d.ts:304:9 - error TS7010: 'release', which lacks return-type annotation, implicitly has an 'any' return type.

304         release();
            ~~~~~~~~~~


Found 1 error in node_modules/pg-promise/typescript/pg-subset.d.ts:304

Please fix it.

vitaly-t added a commit that referenced this issue Nov 27, 2022
@vitaly-t
Copy link
Owner

vitaly-t commented Nov 27, 2022

Addressed in v10.15.4 update. Please confirm and close the issue, if sorted 😉

@vitaly-t vitaly-t added the fixed label Nov 27, 2022
@Lehks
Copy link
Author

Lehks commented Nov 28, 2022

Can confirm, it works now.

@Lehks Lehks closed this as completed Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants