Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic require #42

Closed
wants to merge 3 commits into from
Closed

fix: dynamic require #42

wants to merge 3 commits into from

Conversation

plainnany
Copy link

@plainnany plainnany commented Oct 28, 2023

@yejimeiming
Copy link
Member

Mybe the following code is better.

record.dynaimc = {
  importee: [],
- runtimeName: `__matchRequireRuntime${counter}__`,
+ runtimeName: `__matchRequireRuntime${counter++}__`,
  runtimeFn: '', // to be immediately set
}

@plainnany
Copy link
Author

Mybe the following code is better.

record.dynaimc = {
  importee: [],
- runtimeName: `__matchRequireRuntime${counter}__`,
+ runtimeName: `__matchRequireRuntime${counter++}__`,
  runtimeFn: '', // to be immediately set
}

@yejimeiming counter++ may be used many times,consider using const counter3 = counter++

caoxiemeihao pushed a commit that referenced this pull request Nov 14, 2023
caoxiemeihao pushed a commit that referenced this pull request Nov 14, 2023
@yejimeiming yejimeiming mentioned this pull request Nov 14, 2023
@yejimeiming yejimeiming closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require not supported directly in html and in dynamic import
2 participants