Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle directory and trailing slashes properly #26

Closed
wants to merge 7 commits into from

Conversation

userquin
Copy link
Member

@userquin userquin commented Oct 21, 2023

This PR also includes:

  • add logical manifest entries instead replacing original ones
  • don't add manifestTransform when provided
  • included test folder in pwa-simple example, with index.astro and about.astro routes: /test, /test/, /test/about and /test/about/ working
  • map 404.astro to 404, Astro won't generate the 404/index.html and the sw will fail when precaching 404.html page
  • include StackBlitz links to run the examples: added to readme and included hints to run the PWA
  • bump to pnpm 8.9.2

You can open the pwa-example using this StackBlitz repro

closes #23

@userquin
Copy link
Member Author

superseded by #27

@userquin userquin closed this Oct 27, 2023
@userquin userquin deleted the userquin/fix-allow-custom-manifest-transform branch October 27, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing slash resolves in 404
1 participant