fix: ensure version query for relative node_modules imports #10016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to:
It ensures that relative imports inside
node_modules
are rewritten to include the version hash.Additional context
This problem can cause duplicate modules in development, such as:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
Attempted to create a test case that would trigger this problem, by adding a file inside
dep-non-optimized
with a relative import toindex.js
:After the fix:
Unfortunately, the bug is not triggered because in this test scenario most imports are later rewritten in the
/@fs/
code path (circumventing the problem), so it's not valuable as a test case.