-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): cleaner logs output #10895
Conversation
I like this. At first, about the order from smaller to bigger, my first reaction was to want the opposite but maybe it makes sense to see the biggest files near the prompt. So I think the order is fine. Maybe we could group JS, CSS, and assets files though? I think it is easier to parse if we see them separately, and between each group, we could order them by size. I'm unsure though if some people would prefer to see an alphabetic list, I think it is worth adding this PR to the team board so we can discuss it with the rest. Maybe we need an option here. |
I like this. I was debating the separator (e.g. maybe The grouping idea is an interesting question. I can see arguments either way depending on the scenario. Maybe I just want to optimize load speed regardless of file type and there's chances to do that with both images and JS. Or maybe I have one page with lots of big images and so then maybe I'd want them displayed separately as they're just confined to a single page. After debating it with myself, I think I would be in favor of the grouping. A big reason in my case is that I use |
I like |
Will try to bold the main size. Will also try a "table" layout to avoid repeating "gzip" and "map" now that we have a headers line |
I like the |
Two questions:
|
|
I like the idea of a summary, maybe more interesting even if it is per group. I think we should try first to merge this PR with groups only so we separate the discussions. |
Just my 2 cents, but I think I would prefer a vertical-pipe |
|
In that case you could also try vs |
Rebased on main with display from #10982 I like the stronger separation of |
I also like |
Good point @ArnaudBarre, better to leave it without the extra blank line 👍🏼 |
Like the log redesign ❤️. Just thinking out loud here, should we display JS output files in yellow-ish color like JS logo color, CSS output files in blue-ish color (CSS 3 logo color), and assets files in green? So we could separate JS, CSS, asset files with color and groups. But, I am afraid that yellow-ish JS output files could create a lot of noise since yellow-ish color is similar to warning color? |
@ydcjeff I think playing with the colors is an interesting idea! Let's merge this PR first and then we can create a PR that is only about the colors for each group so we better document the rationale there and don't block this one that is ready to be merged. |
Yeah the yellow is already used for "too big" chunks. But we could try some other colors combinations! |
There are two improvements that goes together:
Before:
Note: IMO map size should not be in yellow.
After:
Note: This is clearly not a carefully optimised webapp, but this new report allow to quickly see images that could be compressed.
Example with chunk size limit & compress size:
Note: In Rollup 3 maps have their own assets entries, so they are currently displayed twice in v4
Open question: I would prefer to display size in
kB
instead ofKiB
. Is there any reason for using the later?