refactor: use function to eval worker and glob options #10999
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
new Function()
to parse worker and glob options. This should allow more flexible options syntax. Fixes #10961This started as an experiment, but it works! But happy to discuss more or ditch this idea if there's concerns.
Additional context
Raw unprocessed benchmark: https://gist.github.com/bluwy/f7d308444eb0821b64354de93220d719
new Function()
is slightly faster overjson5
(worker options), and seem to have equal perf toacorn
(glob options).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).