fix: formatError() outside rollup context #11156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
formatError()
to be able to compute the error frame outside the activeCtx (useful for SSR rendering if app crashes during execution).Right now
formatError()
is not generating the frame automatically, even though throwing a error with all the necessary information.When using Vite with dev SSR, custom user's code might run right after
ssrLoadModule()
and this code could crash, right now it's is missing nice printing, even though the source of the error is known!Additional context
Discussion with @patak-dev
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).