Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): clear console by pressing c (#11493) #11494

Merged
merged 4 commits into from
Jan 4, 2023
Merged

feat(cli): clear console by pressing c (#11493) #11494

merged 4 commits into from
Jan 4, 2023

Conversation

kinfuy
Copy link
Contributor

@kinfuy kinfuy commented Dec 27, 2022 •
edited by bluwy
Loading

Description

Add a new shortcut key to clear the output.

Additional context

closes #11493

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title feat: clear console by pressing c (#11493) feat(cli): clear console by pressing c (#11493) Dec 28, 2022
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 28, 2022
@kinfuy @bluwy
Update packages/vite/src/node/shortcuts.ts
26dbd80 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@dominikg
Copy link
Contributor

please make sure this does not interfere with ctrl-c to cancel the process

@kinfuy
Copy link
Contributor Author

kinfuy commented Jan 1, 2023 •
edited
Loading

please make sure this does not interfere with ctrl-c to cancel the process

This problem is not caused by this PR, I have another PR （#11518）to solve this problem

@sapphi-red
Copy link
Member

please make sure this does not interfere with ctrl-c to cancel the process

I hadn't thought of that. I now tried it and it worked fine on Windows. 👍

patak-dev
patak-dev approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge in 4.1

@patak-dev patak-dev added this to the 4.1 milestone Jan 3, 2023
@sxzz
Copy link
Member

sxzz commented Jan 3, 2023

/cc btw @danielroe hope Nuxt has this feature too 👀

@patak-dev patak-dev merged commit 1ae018f into vitejs:main Jan 4, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@kinfuy @bluwy @futurGH
feat(cli): clear console by pressing c (vitejs#11493) (vitejs#11494)
42c097f 
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@bluwy bluwy bluwy approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@sxzz sxzz sxzz approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Need a new shortcut key to clear the output.
7 participants
@kinfuy @dominikg @sapphi-red @sxzz @patak-dev @ydcjeff @bluwy