fix: remove moment from force interop packages #11502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #10039.
The context could be found here #1724 (comment).
esbuild seems smarter now and won't wrap moment as a CommonJS module anymore. So the workaround could be dropped now.
I tested
moment@2.29.1
which is released on 2020-10-06 and the latest version, and both works fine.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).