-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): ctrl+C no longer kills processes (#11434) #11518
Conversation
0ce958c
to
718b443
Compare
I don't remember what but it causes issues. I need to look at it a bit closer |
I guess it's because |
Co-authored-by: Arnaud Barré <arnaud.barre72@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really neat solution 👍
stil not working in 4.1.1 |
@kinfuy kinfuy |
Can you provide a repro? |
The current processing is that ctrl c directly throws process.exit (1), which is indeed consistent with the behavior of ctrl c's unexpected exit, but this prompt will make people feel sick. Maybe there is a need to find a better way |
Yeah I was annoyed by this extra log but with the team we decided to go in that direction so everything is supported (shortcuts, running via npm-run-all) without configuration. The only other solution would be to allow people to out-out of shortcuts bindings. But that's one more thing to document. |
Co-authored-by: Arnaud Barré <arnaud.barre72@gmail.com> close vitejs#11434
Description
The binding of shortcut keys makes
Ctrl+C
unable to exit the program directly. Although the SIGTERM signal is sent upward, it cannot end when the console has an asynchronous output task. I thinkCtrl+C
should exitprocess.exit(1)
Additional context
close #11434
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).