-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reporter): report built time #12100
Conversation
There seems to be a plugin with similar functionality https://github.com/Shinigami92/vite-plugin-time-reporter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
I personally would like to see this built-in. I think we should wait for Vite 5 to do changes to the output though. We can see what others think and then add it to the milestone. |
Sounds reasonable. I will open a discussion for that. |
We can use this PR to discuss 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea! I don't think we need to wait for Vite 5 though, it seems minor enough that it can fit the next minor (pun not intended).
I'm fine having this in the next minor, we can add it during the beta and check that nobody complains. In part, I wanted to push it to 5 because we have been doing cli output changes on each major and wanted to start accumulating some diffs 👀 |
c169544
to
c795936
Compare
This PR just reports the total build time. Besides, there're 2 extra features we can discuss:
|
Description
To show the total built time after the building completes.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).