fix(define): should not stringify vite internal env

[sun0day]

Description

Some Vite internal env values(e.g plugin-legacy __VITE_IS_LEGACY__) will be stringified, which may cause the value type to be incorrect in import.meta.env object

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[bluwy]

Ah I didn't anticipate this bug, if you have define import.meta.env.SOMETHING: "rawIdentifier". import.meta.env should be:

{
  SOMETHING: rawIdentifer
}

instead of a string. I think we need to do this generically for all define that defines a raw identifier, not just for plugin-legacy.

[bluwy]

I split off env and userDefineEnv as otherwise the define envs get mixed into this for loop, which is harmless in practice, but would be nice to avoid.

[sun0day]

Notice that import.meta.env.SSR will be replaced by user define values.

[bluwy]

I think that might be fine for now as in dev (import analysis), it's allowed to overwrite import.meta.env.SSR too 🤔

vite/packages/vite/src/node/plugins/importAnalysis.ts

Lines 636 to 652 in 3551f75

	if (hasEnv) {
	// inject import.meta.env
	let env = `import.meta.env = ${JSON.stringify({
	...config.env,
	SSR: !!ssr,
	})};`
	// account for user env defines
	for (const key in config.define) {
	if (key.startsWith(`import.meta.env.`)) {
	const val = config.define[key]
	env += `${key} = ${
	typeof val === 'string' ? val : JSON.stringify(val)
	};`
	}
	}
	str().prepend(env)
	}

this code injects the import.meta.env code for each file. Also I just realized we could probably cache this code.

[sun0day]

LGTM

[bluwy]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI: Open

suite	result
astro	✅ success
histoire	✅ success
iles	✅ success
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt-framework	✅ success
previewjs	✅ success
qwik	⏹️ cancelled
rakkas	✅ success
sveltekit	✅ success
vite-plugin-ssr	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	❌ failure
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	✅ success
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	✅ success
windicss	✅ success