refactor: use resolvePackageData
in requireResolveFromRootWithFallback
#12712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
requireResolveFromRootWithFallback
to useresolvePackageData
instead ofresolve.sync
.This function was introduced by ddfcbce and changed by #3988 and #10812.
Previously, this function was using
require.resolve.paths
and was passing this toresolve.sync
andrequire.resolve
. Now this function simply passesroot
and__dirname
. IIUC this behaves same becauserequire.resolve.paths
returns the value ofNODE_MODULES_PATHS
in this all together sectionrequire.resolve
usespaths
option as a starting point for the module resolution algorithm. Alsorequire.resolve
always usesGLOBAL_FOLDERS
. In other words,require.resolve
will usepaths.flatMap(p => NODE_MODULES_PATHS(p))
as candidates.So passing
root
topaths
option ofrequire.resolve
is same with passingcreateRequire(root).resolve.paths
topaths
option.I tested this PR by the way written in #2612 and #10812.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).