-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support async plugins #8574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked as draft. There’s one more case in asyncFlatten that I’ll fix tomorrow. |
I think |
poyoho
reviewed
Jun 14, 2022
tony19
reviewed
Jun 14, 2022
tony19
reviewed
Jun 14, 2022
bluwy
commented
Jun 14, 2022
poyoho
reviewed
Jun 14, 2022
patak-dev
added
p3-significant
High priority enhancement (priority)
and removed
p2-to-be-discussed
Enhancement under consideration (priority)
labels
Jun 17, 2022
patak-dev
previously approved these changes
Jun 17, 2022
We talked about the PR in today's meeting and we decided to move forward. @bluwy once you resolve the conflicts you can merge it 👍🏼 |
patak-dev
approved these changes
Jun 18, 2022
antfu
approved these changes
Jun 18, 2022
Love it! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on discussion: #8509
Support
config.plugins: (Plugin | Plugin[] | Promise<Plugin | Plugin[]>)[]
Additional context
Turns out deep flattening an array of promises only take 3 lines 😄
Side note:
@poyoho it looks like
config.worker.plugins
isn't flatten and being handled with falsy,apply
prop etc like:vite/packages/vite/src/node/config.ts
Lines 333 to 343 in c5c424a
Is it intentional?
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).