Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: legacy options to revert to v2 strategies #8623

Merged
merged 14 commits into from
Jun 17, 2022
Merged

feat: legacy options to revert to v2 strategies #8623

merged 14 commits into from
Jun 17, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Jun 16, 2022 •
edited
Loading

Description

Add new options marked as experimental and deprecated to revert to v2 strategies, and express clear intent that these may be removed in a v3 minor

  • legacy.devDepsScanner
  • legacy.buildRollupPluginCommonjs
  • legacy.buildSsrCjsExternalHeuristics

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev changed the title fix: allow cache overlap in parallel builds feat: experimental options to revert to v2 strategies Jun 16, 2022
@patak-dev patak-dev added the p3-significant High priority enhancement (priority) label Jun 16, 2022
bluwy
bluwy reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might need new docs for the experimental options. And also, perhaps we should deprecate build.commonjsOptions too?

docs/guide/migration.md Outdated Show resolved Hide resolved
docs/guide/migration.md Outdated Show resolved Hide resolved
docs/guide/migration.md Outdated Show resolved Hide resolved
@antfu
Copy link
Member

antfu commented Jun 17, 2022

experimental feel a bit future-oriented to me. Maybe we could introduce them as legacy. or compact.?

@patak-dev patak-dev changed the title feat: experimental options to revert to v2 strategies feat: legacy options to revert to v2 strategies Jun 17, 2022
@patak-dev
Copy link
Member Author

Thanks @antfu, legacy sounds a lot better to me. Changed the PR to use it 👍🏼
I still marked these three options as @experimental so we can break semver in a future minor removing them without breaking the contract for Vite itself.

sapphi-red
sapphi-red reviewed Jun 17, 2022
View reviewed changes
docs/guide/migration.md Outdated Show resolved Hide resolved
docs/guide/migration.md Outdated Show resolved Hide resolved
patak-dev and others added 3 commits June 17, 2022 12:22
@patak-dev @sapphi-red
chore: spacing
9ddfab6 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev @sapphi-red
chore: thanks sapphi
e8c086d 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev
chore: format
9ba3950
sapphi-red
sapphi-red reviewed Jun 17, 2022
View reviewed changes
docs/guide/migration.md Outdated Show resolved Hide resolved
@patak-dev @sapphi-red
chore: update
4b4c895 
Co-authored-by: 翠 / green <green@sapphi.red>
@sapphi-red sapphi-red mentioned this pull request Jun 17, 2022
Merged
9 tasks
sapphi-red
sapphi-red previously approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo and diff is including #8592 for some reason but LGTM

docs/guide/migration.md Outdated Show resolved Hide resolved
@patak-dev @sapphi-red
chore: fix typo
165fba6 
Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev patak-dev merged commit 993b842 into main Jun 17, 2022
@patak-dev patak-dev deleted the feat/deprecate-commonjs-plugin branch June 17, 2022 18:58
@sapphi-red sapphi-red mentioned this pull request Jun 19, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy left review comments

@sapphi-red sapphi-red sapphi-red left review comments

Assignees
No one assigned
Labels
p3-significant High priority enhancement (priority)
Projects
Team Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patak-dev @antfu @bluwy @sapphi-red