Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): use debug channel on hot updates #8855

Merged
merged 1 commit into from
Aug 26, 2022
Merged

feat(client): use debug channel on hot updates #8855

merged 1 commit into from
Aug 26, 2022

Conversation

innocenzi
Copy link
Contributor

Description

This PR changes the console.log related to HMR updated from the client to console.debug, in order to avoid getting spammed in the console.

Recently, [vite] connecting... and [vite] connected. have been moved to the debug channel as well in #7733.

image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6cf64e9
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62bc522d12104000090e1cbd

@patak-dev patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label Jun 30, 2022
@patak-dev patak-dev changed the title fix(client): use debug channel on hot updates feat(client): use debug channel on hot updates Aug 26, 2022
@patak-dev patak-dev merged commit 0452224 into vitejs:main Aug 26, 2022
@innocenzi innocenzi deleted the fix/hot-updates-debug-channel branch August 26, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-to-be-discussed Enhancement under consideration (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants