Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#8808 completely removed drive-relative path resolution behavior.
I removed this because I thought it was not intended: it was resolving using
process.cwd()
as a base, not the importer.But I found that node.js supports drive-relative path resolution (nodejs/node#31710) and now I think this should be implemented.
This PR implements drive-relative path resolution (with the correct base). In addition, this PR adds absolute path resolution test.
Additional context
I tested the behavior of drive-relative path by:
$ node D:\foo.mjs
onpwd = C:\
D:\foo.mjs
D:\bar.js
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).