feat: allow declaring __dirname
in config
#9154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
__dirname
/__filename
cannot be declared at top level in config files since Vite injects those variables.The code below is a common pattern but an error will happen.
This PR makes it possible to declare those at top level.
esbuild's define only replaces top-level values (it's not a static replace) so this works.
refs #9147
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).