fix: ignore tsconfig target when bundling config #9457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
target: es5
is set intsconfig.json
andvite.config.ts
exists, Vite fails to start.This is because esbuild looks for that when bundling config.
Because we always ignore
target
intsconfig.json
and users won't expecttarget
field to be respected for config loading, I think it is better to ignoretarget
field here too.reproduction: https://stackblitz.com/edit/vitejs-vite-h1gxde?file=vite.config.ts&terminal=dev
Additional context
related discussion: #3827
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).