-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo #9855
docs: fix typo #9855
Conversation
@@ -18,7 +18,7 @@ test('deep import with exports field', async () => { | |||
}) | |||
|
|||
test('deep import with query with exports field', async () => { | |||
// since it is imported with `?url` it should return a url | |||
// since it is imported with `?url` it should return an url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// since it is imported with `?url` it should return an url | |
// since it is imported with `?url` it should return a URL |
Similar to issue above with the unsounded h
, use a
before a sounded u
.
playground/wasm/vite.config.ts
Outdated
@@ -1,7 +1,7 @@ | |||
import { defineConfig } from 'vite' | |||
export default defineConfig({ | |||
build: { | |||
// make can no emit light.wasm | |||
// make can not emit light.wasm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// make can not emit light.wasm | |
// make cannot emit light.wasm |
@@ -394,7 +394,7 @@ function tryFsResolve( | |||
|
|||
let res: string | undefined | |||
|
|||
// if we fould postfix exist, we should first try resolving file with postfix. details see #4703. | |||
// if we found postfix exist, we should first try resolving file with postfix. details see #4703. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// if we found postfix exist, we should first try resolving file with postfix. details see #4703. | |
// if a postfix exists, we should first try resolving file with postfix. details see #4703. |
packages/vite/src/node/server/ws.ts
Outdated
@@ -108,7 +108,7 @@ export function createWebSocketServer( | |||
const port = hmrPort || 24678 | |||
const host = (hmr && hmr.host) || undefined | |||
if (httpsOptions) { | |||
// if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves | |||
// if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves | |
// if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves |
The original text is correct. Use an
before an unsounded h
.
@tony19 Thanks for the review, I have fixed all the issues you raised. |
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).