-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update esbuild compilation affecting fields #10374
Merged
patak-dev
merged 2 commits into
vitejs:main
from
sapphi-red:feat/update-esbuild-compilation-fields
Oct 14, 2022
Merged
feat: update esbuild compilation affecting fields #10374
patak-dev
merged 2 commits into
vitejs:main
from
sapphi-red:feat/update-esbuild-compilation-fields
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
Not breaking anything but nice to have (priority)
label
Oct 7, 2022
bluwy
approved these changes
Oct 14, 2022
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
I think vitepress will be fixed by #10375. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
It seems svelte and vite-plugin-ssr are failing with v3.2.0-beta.2 too. |
patak-dev
approved these changes
Oct 14, 2022
sapphi-red
added a commit
to sapphi-red/vite
that referenced
this pull request
Oct 30, 2022
This reverts commit f542727.
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Oct 30, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
alwaysStrict
,jsx
,jsxImportSource
fields when transpiling TS.https://esbuild.github.io/content-types/#tsconfig-json
jsx
,jsxImportSource
is supported by evanw/esbuild#2349 that is supported from esbuild v0.14.51+.I'm not sure if we should include
alwaysStrict
. Rollup will always output"use strict";
unlessstrict: false
is set. (and ESM is always strict mode)Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).