Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): cannot reload after missing import on server startup (#9534) #10602

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

tuchg
Copy link
Contributor

@tuchg tuchg commented Oct 23, 2022

Description

When the devserver is started for the first time, this error will occur if a nested missing import relationship is encountered. For details, please see the playground's missing import test in the commit and the releated issue.

Additional context

close: #9534

the bug comes from pr #8898 . It seems just to be to adjust the logs display effect? Now it seems that some updates cannot be accurately tracked by the updates array, so it follows the previous implementation of versions to send update and execute transform function


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

Thank you for the PR!

I think we should set importerModule.isSelfAccepting = false when an error is thrown in import-analysis plugin.
For example,

@sapphi-red sapphi-red added feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Oct 25, 2022
@tuchg
Copy link
Contributor Author

tuchg commented Oct 25, 2022

Thank you for the PR!

I think we should set importerModule.isSelfAccepting = false when an error is thrown in import-analysis plugin. For example,

@sapphi-red yes, u're right. The reason is that isSelfAccepting is missing and lead to stop propagating updates , but I didn't think of this entry. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 3 regression: missing reload after fixing import error existing on dev server startup
3 participants