-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gracefully handle forbidden filesystem access #10793
Conversation
Note: just a detail, but about the "is self explanatory" in the Description, IMO you could avoid that line and directly add the Additional Context line instead there. |
2842fd6
to
343e206
Compare
I added unit tests and rewrote I also removed comments that weren't useful. (The comments were linking to #2051 which doesn't provide much information.) The new implementation only uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brillout! This looks good to me now.
Description
Prior to this PR, URLs like
/root
make Vite throw an error.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).