fix(ssr): preserve require for external node #11057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #10406. The change is 3789d8f.This fixes what #10450 tried to fix.
When
require('B')
written in A is converted toimport 'B'
. But convertingrequire
intoimport
is not always safe. For example, if B usesexports
field and uses different files.This PR fixes this by preserving
require
as-is for SSR with node target.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).