Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade resolve.exports #11712

Merged
merged 1 commit into from
Jan 18, 2023
Merged

refactor: upgrade resolve.exports #11712

merged 1 commit into from
Jan 18, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 17, 2023

Description

Upgrade resolve.exports to v2 to handle breaking changes, and allow other PRs to use it's new imports API to support subpath imports.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Jan 17, 2023
@patak-dev patak-dev merged commit 00a79ec into main Jan 18, 2023
@patak-dev patak-dev deleted the upgrade-resolve-exports branch January 18, 2023 16:25
@benmccann benmccann mentioned this pull request Jan 26, 2023
Merged
9 tasks
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
refactor: upgrade resolve.exports (vitejs#11712)
4c5785f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @patak-dev @sapphi-red