Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow package subpaths in ssr.noExternal #11817

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cyco130
Copy link
Contributor

@cyco130 cyco130 commented Jan 26, 2023

Description

I often need to package a Vite plugin along with some runtime library and some piece of code that requires processing by Vite. I want the runtime entry to be externalized for SSR but the entry that requires processing (maybe a virtual module) not to be externalized. Without this PR, it is not easily possible because ssr.external accepts subpaths but ssr.noExternal doesn't. Furthermore, a package name in ssr.external is interpreted as applying to all subpaths of that package. This PR modifies the algorithm to check if the ID is in ssr.noExternal before applying the previous rule.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@cyco130 cyco130 changed the title Allow package subpaths in ssr.noExternal feat: allow package subpaths in ssr.noExternal Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant