feat: allow package subpaths in ssr.noExternal #11817
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I often need to package a Vite plugin along with some runtime library and some piece of code that requires processing by Vite. I want the runtime entry to be externalized for SSR but the entry that requires processing (maybe a virtual module) not to be externalized. Without this PR, it is not easily possible because
ssr.external
accepts subpaths butssr.noExternal
doesn't. Furthermore, a package name inssr.external
is interpreted as applying to all subpaths of that package. This PR modifies the algorithm to check if the ID is inssr.noExternal
before applying the previous rule.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).