build: correct d.ts output dir in development #12212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dev mode for vite, d.ts is generated to
dist/dist/node
which is not correct.While
package.json
is write asvite/packages/vite/package.json
Lines 20 to 31 in 2aad552
So no
d.ts
could be found in dev mode.Change the abs path to a relative path to correct the output behavior. I haven't quite figured out the logic here https://github.com/rollup/plugins/blob/bc5cf91a042b88e14a1da9ba25f501d92591ca8a/packages/typescript/src/index.ts#L152-L182. But seems like it's more conventional to use a relative path as
output.dir
. So I changed it to relative path and everything goes well now. 😅Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).