Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): suppress esbuild cancel error #12358

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 10, 2023

Description

When esbuildContext.rebuild() is called, then esbuildContext.cancel() is called, esbuild logs an error, which we don't want as we're intentionally cancelling the build. This PR checks the error message and suppresses it.

Additional context

This should fix the logs appearing in Astro's ecosystem-ci unit tests, since the unit test runs server restarts consecutively, triggering this error. Though even with the error logs, the test passes, but this change should help avoid confusion.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 10, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-dev patak-dev merged commit 86a24e4 into main Mar 10, 2023
@patak-dev patak-dev deleted the fix-esbuild-cancel-error branch March 10, 2023 10:03
@mkilpatrick mkilpatrick mentioned this pull request Jan 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants