Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opus filetype to assets & mime types #12526

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat: add opus filetype to assets & mime types #12526

merged 1 commit into from
Mar 22, 2023

Conversation

mia-riezebos
Copy link
Contributor

@mia-riezebos mia-riezebos commented Mar 22, 2023

Description

the web is using the opus codec more and more for audio streaming, to mentally separate these from ogg:vorbis, some people use the .opus file extension. I wanted to do this for a project of mine as well, and figured i'd add it to the main vite repo.

Additional context

mostly concerned about whether ive used the mrmime part correctly to add opus?

this failed 1 test that seems unrelated (building on windows might be the culprit), see below:

 RUN  v0.29.7 C:/Users/mia/libraries/side-projects/vite

·····-····································································-············x···············-·····················-······································································--·········-···················································-------·····································-·········-·····----·····--··-···--·--········--·······················--·······················-----------·············--····································--··························--·-················--····---·-··············-·--····---···············--···-·······---------------------------

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  playground/preserve-symlinks/__tests__/preserve-symlinks.spec.ts > not-preserve-symlinks
AssertionError: expected '' to be 'hello vite' // Object.is equality
 ❯ playground/preserve-symlinks/__tests__/preserve-symlinks.spec.ts:11:43
      9| 
     10| test('not-preserve-symlinks', async () => {
     11|   expect(await page.textContent('#root')).toBe('hello vite')
       |                                           ^
     12| })
     13| 

  - Expected   "hello vite"
  + Received   ""

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 56 passed | 10 skipped (67)
      Tests  1 failed | 508 passed | 91 skipped (600)
   Start at  03:11:26
   Duration  87.90s (transform 12.33s, setup 108.59s, collect 25.26s, tests 389.36s)

 ELIFECYCLE  Command failed with exit code 1.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • [x ] Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mia-riezebos mia-riezebos changed the title add opus filetype to assets & mime types feat: add opus filetype to assets & mime types Mar 22, 2023
@patak-dev patak-dev enabled auto-merge (squash) March 22, 2023 06:17
@patak-dev patak-dev merged commit 63524ba into vitejs:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants