perf(ssr): calculate stacktrace offset lazily #13256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working on a cli which uses vite as a dependency.
I'm also using the
source-map-support
package to transform error stacktrace frames.When running the cli, the vite module is loaded. During the load, it eagerly creates an
Error
and accesses itsstack
property, which triggers source mapping.This is pretty slow and incurs a few hundred ms on my cli's startup time (might be different numbers on different hardware).
Proposed solution - calculate the offset (which accesses
stack
) lazily - only when we actually need to rewrite an ssr stacktrace.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).