Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nest deps chunk cannot be loaded when optimizing deps in build mode #13935

Closed
wants to merge 1 commit into from

Conversation

ChuHoMan
Copy link

Description

fixes #13933
Align the load logic of optimizedDepsBuildPlugin with optimizedDepsPlugin. After loading the file from the cache, throw an exception if an error is encountered.

Additional context

As mentioned in the last context I provided in the issue. I noticed that the file field for the chunks in the .vite/deps/_metadata.json is processed with flattenId. But the chunk files generated by esbuild on the disk do not undergo the flattenId process. Is this behavior expected? If it's necessary to flatten the chunk filenames, would it be better to flatten the filenames when generating the chunk files with esbuild? However, at the moment, I'm not sure how to flatten the generated chunks.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ChuHoMan ChuHoMan changed the title fix: Nest deps chunk cannot be loaded when optimizing deps in build mode fix: nest deps chunk cannot be loaded when optimizing deps in build mode Jul 23, 2023
@ChuHoMan
Copy link
Author

@bluwy Sorry to bother you, let me know if you have any feedback on this bug fix.

@sapphi-red
Copy link
Member

Closing as the build-time dep-optimization is now removed (#15184).

@sapphi-red sapphi-red closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest deps chunk cannot be loaded when optimizing deps in build mode
2 participants