Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): ctrl + c closes the server without exit code #14319

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 7, 2023

Description

If the shutdown process includes an exit code, it looks like something went wrong.

image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea btea changed the title fix(node): ctr + c closes the server without exit code fix(node): ctrl + c closes the server without exit code Sep 7, 2023
@bluwy
Copy link
Member

bluwy commented Sep 8, 2023

Exit 1 is intentional in #11563, however in Vite 5 we also plan to move away from setRawMode so that can also fix this issue.

@btea
Copy link
Collaborator Author

btea commented Sep 9, 2023

OK, thank you for the reference link. However, as the comment says, the return statement can perhaps be removed.

Maybe we can wait until your Vite 5 plan to solve it together.

@bluwy bluwy mentioned this pull request Sep 10, 2023
4 tasks
@bluwy bluwy closed this in #14342 Sep 21, 2023
@btea btea deleted the fix/remove-shortcur-exit-code branch September 21, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants