Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(imports): support import attributes - fixes #14674 #15654

Closed
wants to merge 3 commits into from

Conversation

matthewp
Copy link
Contributor

Description

Fixes #14674

Adds support for import attributes by parsing them in the import analysis plugin.

Additional context

How this works:

  • es-module-lexer provides information about where the attributes are. We already use this to clip them off.
  • We grab the string, which is an object literal { foo: 'bar' }
  • We use Acorn to parse this string.
  • Iterate over the AST to extract the values into an object
  • Pass this through to resolveId where plugins can do what they want.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@matthewp
Copy link
Contributor Author

I'm not sure why this is failing in CI, likely a race condition some how. I'll take a look.

@matthewp
Copy link
Contributor Author

I'm not working on this at the moment, so closing.

@matthewp matthewp closed this Feb 11, 2024
coxmi added a commit to coxmi/ssr-tools that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite plugins drop import attributes/assertions property only from src not node_modules
2 participants