Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): dynamic import browserslist-to-esbuild #16011

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 22, 2024

Description

fix #15988 (comment)

browserslist-to-esbuild is ESM only, so we need to dynamically import it.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Feb 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Member Author

bluwy commented Feb 22, 2024

/ecosystem-ci run

@patak-dev
Copy link
Member

Thanks Bjorn!

It seems Qwik and Rakkas are failing because of a puppeteer issue. Yesterday they were working but it doesn't look like this is in our side:
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/8005837497/job/21866210713#step:8:1253

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 1c61e19: Open

suite result latest scheduled
analogjs success success
astro success success
histoire success success
ladle success success
laravel success success
marko success success
nuxt success success
nx failure failure
previewjs success success
qwik failure success
rakkas failure success
sveltekit success success
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

@patak-dev patak-dev merged commit 42fd11c into main Feb 22, 2024
10 checks passed
@patak-dev patak-dev deleted the fix-legacy-cjs branch February 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants