Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest): do not fail when using rollupOtions.external #2353

Merged
merged 1 commit into from
Mar 5, 2021
Merged

fix(manifest): do not fail when using rollupOtions.external #2353

merged 1 commit into from
Mar 5, 2021

Conversation

CHOYSEN
Copy link
Contributor

@CHOYSEN CHOYSEN commented Mar 3, 2021

Fix #2347

@underfin underfin merged commit b05a567 into vitejs:main Mar 5, 2021
@userquin userquin mentioned this pull request Mar 6, 2021
Closed
@CHOYSEN CHOYSEN deleted the fix_manifest branch March 15, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

facadeModuleId error when enabling manifest option with rollup externals
2 participants
@CHOYSEN @underfin