fix(plugin-legacy): wrap legacy chunks in IIFE (IE11) #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
the
p3-minor-bug
antfu
changed the title
antfu
previously approved these changes
Apr 13, 2021
template literals in our legacy chunks got randomly overwritten (gql mixed with emotion) in legacy build the problem was that at the top of the file there were `var lit1, lit2, lit3` declarations and those were evaluated in global scope this resolves the issue
|
renamed commit to fit standards, no other change |
antfu
approved these changes
Apr 14, 2021
patak-dev
previously approved these changes
Apr 14, 2021
patak-dev
reviewed
Apr 14, 2021
| @@ -260,7 +260,7 @@ function viteLegacyPlugin(options = {}) { | |||
| ] | |||
| }) | |||
|
|
|||
| return { code, map } | |||
| return { code: `;(function(){${code}})();`, map } | |||
There was a problem hiding this comment.
@cztomsik shouldn't the sourcemap (map) be also updated? Using magic-string for example
There was a problem hiding this comment.
good point but I'm busy now so maybe later or somebody else can fix it properly, this is just what worked for us
9 tasks
|
Thanks for the PR, closing this one as #3783 was merged now. |
|
No worries, thanks @umidbekk for fixing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
template literals in our legacy chunks got randomly overwritten (gql mixed with emotion) in legacy build
the problem was that at the top of the file there were
var lit1, lit2, lit3declarations and those were evaluated in global scope. this resolves the issueAdditional context
I was surprised that systemjs does not wrap files in IIFE itself
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).