Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-legacy): wrap legacy chunks in IIFE (IE11) #2972

Closed
wants to merge 1 commit into from
Closed

fix(plugin-legacy): wrap legacy chunks in IIFE (IE11) #2972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-legacy/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ function viteLegacyPlugin(options = {}) {
]
})

return { code, map }
return { code: `;(function(){${code}})();`, map }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cztomsik shouldn't the sourcemap (map) be also updated? Using magic-string for example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point but I'm busy now so maybe later or somebody else can fix it properly, this is just what worked for us

},

transformIndexHtml(html, { chunk }) {
Expand Down