Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-app): lit-element templates package.json #3435

Merged
merged 1 commit into from
May 16, 2021
Merged

fix(create-app): lit-element templates package.json #3435

merged 1 commit into from
May 16, 2021

Conversation

patak-dev
Copy link
Member

Description

Modify names in package.json of lit templates so they are unique and Jest stop issuing a warning.

Correct main and exports fields that were pointing to the wrong file, check vite.config.js of templates.

I don't know why we are generating a lib and not an app for lit templates. I imagine that the Lit team will switch these templates to an app when they update them to Lit 2.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 74986d3 into vitejs:main May 16, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants